-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh Layer Rendering with Updated Canvas Fix #59987
base: master
Are you sure you want to change the base?
Mesh Layer Rendering with Updated Canvas Fix #59987
Conversation
This reverts commit 5d8fbcc.
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
…on (avoids double rendering of the mesh layer)
@@ -17184,12 +17184,6 @@ void QgisApp::handleRenderedLayerStatistics() const | |||
QgsMeshLayer *meshLayer = qobject_cast<QgsMeshLayer *>( QgsProject::instance()->mapLayer( layerStatistics->layerId() ) ); | |||
if ( meshLayer ) | |||
{ | |||
QgsMeshRendererSettings rendererSettings = meshLayer->rendererSettings(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this logic applied now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is applied in step of renderer creation. Basically, this part of the logic was applied twice, which caused issue (double rendering).
There is significant difference between mesh and raster renderer - mesh renderer is not stored at all, only the settings and mesh renderer is always created when it is needed. Thus there is no refresh
of it.
I am not 100% sure that I properly understand the approach that was introduced with QgsRenderedLayerStatistics
. Should the layer statistics be only applied on the renderer from this part of the code? And if rendered from anywhere else, just stick with data that are already set in mesh render settings?
I updated this to follow the use of On creation of the renderer the This should fix the rendering pipeline, to be correct. |
Description
There was a regression in Mesh Layer rendering for scalar datasets in case of "Updated Canvas" extent. This PR fixes it and also fixes fixes issue with style setting panel that could cause QGIS crash (test case was for this was added).
cc @uclaros