Hotfix: Exclude flux pulses from subsection splitting logic if they overlap (in time) with readout #848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, the ZI driver was designed so that it splits incoming pulse sequence based on the locations of measurement. This was motivated by some limitations in laboneq, (at least) part of which no longer exist. Eventually the driver will be rewritten to remove the assumptions related to this logic, but for now to make this experiment work, this PR implements a hotfix.
See also discussion in #840
Tested for qubit 1 with qiboteam/qibocal#691 and qiboteam/qibolab_platforms_qrc#126 (but updated the power range of flux lines from 9 to 1).
Qubit flux dependence:
Resonator flux dependence:
P.S. The amplitude sweeps are indeed flux pulse amplitude sweeps. The axis is incorrectly named bias (see qiboteam/qibocal#691 (review))
Before this change, the right plots (i.e. the ones with flux pulse amplitude sweep) would look like as below (example plot for qubit flux dependence). I.e. the sweep wouldn't happen at all. This is because the long flux pulse overlapping with measurement was dropped.
Checklist: