Add fidelities

[Jacfomg]

Add fidelitiy attributes

Checklist:

• Reviewers confirm new code works as expected.
• Tests are passing.
• Coverage does not decrease.
• Documentation is updated.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.72%. Comparing base (a964ab2) to head (397ce65).
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   66.64%   66.72%   +0.07%     
==========================================
  Files          55       55              
  Lines        5954     5968      +14     
==========================================
+ Hits         3968     3982      +14     
  Misses       1986     1986              

Flag	Coverage Δ
unittests	66.72% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alecandido]

I agree with @stavros11 comments. I'm adding a few style-related comments.

However, in general I'd try to have a fixed layout, and instead of making operations conditional on something (like the if pairs: branchings) I'd rather try to design the code to work smoothly in limit cases (i.e. if you get an empty dictionary, you just do nothing, and you shouldn't need any further conditional). Moreover, keeping a fixed layout makes it simpler to avoid branching.
However, in this case maintaining compatibility is likely more relevant, so please follow @stavros11 advice.

[alecandido]

Where are these names coming from?

[stavros11]

qibolab/src/qibolab/qubits.py

Line 166 in 00ade29

qubit1: Qubit

since now EXCLUDE_FIELDS is also used in QubitPair

qibolab/src/qibolab/qubits.py

Line 193 in 00ade29

if fld.name not in EXCLUDED_FIELDS

[alecandido]

I now wonder whether it would be a better option to have one each...

Btw, we don't even strictly need the EXCLUDED_FIELDS constant, but we could use field(..., metadata={"excluded": True}) or use Annotated[..., EXCLUDED] as type hint (defining an EXCLUDED constant), to keep it local to the ignored field.

[alecandido]

(a possible way of defining unique constants can be found in the standard library https://github.com/python/cpython/blob/b03d71d0d8415281e71ae4f1455222db4b4b66d2/Lib/dataclasses.py#L184-L186)

(at runtime, you could filter dataclass.fields() by using EXCLUDED not in field.type.__metadata__)

[alecandido]

Suggested change

	if pairs:
	if pairs is not None:

[Jacfomg]

pairs is an empty dictionary, if I make it a None when there is no qubit pairs it will start complaining in several places when it gets asked for values. So could I keep this to check for empty dictionaries ?

[stavros11]

I guess he meant len(pairs) > 0.

[Jacfomg]

Ah sure, that I can do

[Jacfomg]

Thanks @stavros11