feat(containers): remove '.copy' method from ContainerBase. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
force-pushed
the
ljg/memh5-copy
branch
2 times, most recently
from
46d8be5 to
a975654
Compare
ljgray
force-pushed
the
ljg/memh5-copy
branch
from
e88ef89 to
ecd720c
Compare
ljgray
force-pushed
the
ljg/memh5-copy
branch
from
ecd720c to
dd91600
Compare
ljgray
force-pushed
the
ljg/memh5-copy
branch
from
dd91600 to
aae4e74
Compare
ljgray
force-pushed
the
ljg/memh5-copy
branch
from
aae4e74 to
c4c16a0
Compare
ljgray
force-pushed
the
ljg/memh5-copy
branch
3 times, most recently
from
614ee37 to
8a0f45c
Compare
This method has been implemented in 'MemDiskGroup' in 'caput.memh5', so there is no need to overwrite it here now.
|
@ketiltrout This should now be fine after merging radiocosmology/caput#239 |
ketiltrout
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has been implemented in 'MemDiskGroup' in 'caput.memh5', so there is no need to overwrite it here now.
Relies on radiocosmology/caput#239 to properly implement shared datasets.