This repository has been archived by the owner on Jul 16, 2019. It is now read-only.
[WIP] Remove stale join code, update tests #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrocklin ping |
|
i thought we were going to put this PR on the back burner while we sort out sorted joins in cuDF ? |
He asked for me to ping him just so he could take a look. I'm happy to put this on the back burner. |
|
I took a brief look at this. My attempt was to add a tiny join method that would route things to the merge method. It turns out that i don't fully understand the expectations of the join API though and how it relates to things like index merging and so on. After a bit of time I gave up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.