PHP 8.4: Implicitly nullable parameters deprecated #158
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update functions.php
|
@cboden do you mind reviewing this? Do you plan to continue maintaining this project or should we fork it? |
|
Another developer has stated they are considering dropping safe altogether as PHPStan is enough. shish/safe also seems to be maintained as an alternative package. |
|
@danepowell I will take a look at this PR and ratchetphp/RFC6455#71 Right now, composer has a minimum PHP version at 5.4. Adding the explicit nullable parameter will require a minimum version bump to 7.1. I have no problem changing the minimum version as long as it is good with @cboden. |
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly marking parameters as nullable is deprecated, the explicit nullable type must be used instead