log: add new log package that uses slog as global logger #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log package provides top-level funtions for creating log records in four different log levels as well as some other helper functions to set up the logging parameters and create special log handlers. Two slog handlers are created: the MultiHandler that allows distributing the logs to several io.Writer objects and the CustomHandler to produce the log output in a specifc format. The certdb.Check type is also modified to add two new fields: a logger and a log archive where the check's log will be stored. The check's logger has the two handlers described above chained, so that the log output is written to the log file and to the check's log archive. A log file has been created with a default name cnf-test-log. Only a couple of log lines have been produces using this new logger as an example. The bulk of the work for converting the old log lines so that they use the new package will be done in a separate change.
sebrandon1
reviewed
Nov 28, 2023
greyerof
approved these changes
Nov 29, 2023
sebrandon1
approved these changes
Nov 30, 2023
jmontesi
merged commit a712625
into
redhat-best-practices-for-k8s:ginkgo_removal
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log package provides top-level funtions for creating log records in four different log levels as well as some other helper functions to set up the logging parameters and create special log handlers.
Two slog handlers are created: the
MultiHandlerthat allows distributing the logs to several io.Writer objects and theCustomHandlerto produce the log output in a specifc format.The
checksdb.Checktype is also modified to add two new fields: a logger and a log archive where the check's log will be stored. The check's logger has the two handlers described above chained, so that the log output is written to the log file and to the check's log archive.A log file has been created with a default name cnf-test-log.
Only a couple of log lines have been produces using this new logger as an example. The bulk of the work for converting the old log lines so that they use the new package will be done in a separate change.