Avoid loading preflight checks in web server mode. #1692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary workaround to allow running the app in web server mode when no kubeconfig file/env var has been provided. For preflight, the clientsholder needs to be fully and correctly initialized in order to run the checks, otherwise it won't have any TestEnvironment to get the containers/operators under test. For web server mode, there's no need to have a valid clientsholder yet, as the kubeconfig file is provided via web form, and it can be a different one on each run. The clientsholder is then created with the clientsholder.GetNewClientsHolder(). This workaround should probably be removed/refactored when PR redhat-best-practices-for-k8s#1684 is merged.
edcdavid
reviewed
Dec 5, 2023
| if preflight.ShouldRun(labelsExpr) { | ||
| // Avoid loading preflight checks in webserver mode, since the app may start | ||
| // without any kubeconfig file provided. | ||
| if !webServerMode && preflight.ShouldRun(labelsExpr) { |
There was a problem hiding this comment.
proposed long term solution at: #1696
|
Closing PR in favour of #1696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround to allow running the app in web server mode when no kubeconfig file/env var has been provided.
For preflight, the clientsholder needs to be fully and correctly initialized in order to run the checks, otherwise it won't have any TestEnvironment to get the containers/operators under test.
For web server mode, there's no need to have a valid clientsholder yet, as the kubeconfig file is provided via web form, and it can be a different one on each run. The clientsholder is then created with the clientsholder.GetNewClientsHolder().
This workaround should probably be removed/refactored when PR #1684 is merged.