Move flags processing to run function #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyerof
approved these changes
Dec 7, 2023
jmontesi
reviewed
Dec 7, 2023
edcdavid
force-pushed
the
move-flags-processing
branch
from
70331fb to
add4252
Compare
jmontesi
approved these changes
Dec 7, 2023
jmontesi
reviewed
Dec 7, 2023
edcdavid
merged commit ced8f5c
into
redhat-best-practices-for-k8s:ginkgo_removal
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the long term solution of : #1692, why not moving the flags processing to the run function and make a new flags package?