Add return code if test suite has a failure #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edcdavid
reviewed
Dec 7, 2023
Add SkipModeAny()
sebrandon1
force-pushed
the
return_code
branch
from
db523ba to
c039f60
Compare
edcdavid
approved these changes
Dec 7, 2023
greyerof
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ginkgo_removalbranch needs to be able to returnexit(1)if there are any nonCompliantObjects found in the checks.Bonus:
testSecConPrivilegeEscalationandtestContainerHostPortfuncs to properly set compliantObjects.StringInSliceto be explicit with type because of linter failures.