to add a msg about the k8s bug #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdavid
reviewed
Dec 13, 2023
rdavid
approved these changes
Dec 13, 2023
edcdavid
reviewed
Dec 13, 2023
edcdavid
reviewed
Dec 14, 2023
edcdavid
reviewed
Dec 14, 2023
| @@ -224,7 +224,9 @@ func testContainersPostStart(env *provider.TestEnvironment) { | |||
| tnf.ClaimFilePrintf("%s does not have postStart defined", cut) | |||
| nonCompliantObjects = append(nonCompliantObjects, testhelper.NewContainerReportObject(cut.Namespace, cut.Podname, cut.Name, "Container does not have postStart defined", false)) | |||
| } else { | |||
| compliantObjects = append(compliantObjects, testhelper.NewContainerReportObject(cut.Namespace, cut.Podname, cut.Name, "Container has postStart defined", true)) | |||
| compliantObjects = append(compliantObjects, testhelper.NewContainerReportObject(cut.Namespace, cut.Podname, cut.Name, "Container has postStart defined,"+ | |||
There was a problem hiding this comment.
Was the intent to add this to the main branch or ginkgo_removal?
There was a problem hiding this comment.
its for both so i need to recreate on ginkgo_removal?
sebrandon1
approved these changes
Dec 15, 2023
edcdavid
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.