Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to add a msg about the k8s bug #1720

Merged
merged 4 commits into from
Dec 15, 2023
Merged

to add a msg about the k8s bug #1720

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dea85c1
to add a msg about the k8s bug
aabughosh Dec 13, 2023
ea48a37
Update suite.go
aabughosh Dec 14, 2023
b57af77
Merge branch 'main' into warnnMsg
aabughosh Dec 14, 2023
18df0ca
Update suite.go
aabughosh Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cnf-certification-test/lifecycle/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ func testContainersPostStart(env *provider.TestEnvironment) {
tnf.ClaimFilePrintf("%s does not have postStart defined", cut)
nonCompliantObjects = append(nonCompliantObjects, testhelper.NewContainerReportObject(cut.Namespace, cut.Podname, cut.Name, "Container does not have postStart defined", false))
} else {
logrus.Warn("Pay attention: A pod with a still running postStart lifecycle hook that is deleted is not terminated even after terminationGracePeriod, thats known upstream bug")
aabughosh marked this conversation as resolved.
Show resolved Hide resolved
aabughosh marked this conversation as resolved.
Show resolved Hide resolved
compliantObjects = append(compliantObjects, testhelper.NewContainerReportObject(cut.Namespace, cut.Podname, cut.Name, "Container has postStart defined", true))
}
}
Expand Down
Loading