Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding storage gloss terms #445

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Adding storage gloss terms #445

merged 1 commit into from
Mar 26, 2024

Conversation

bergerhoffer
Copy link
Collaborator

@bergerhoffer bergerhoffer commented Feb 27, 2024 •
edited
Loading

Taking over #335 to get it over the finish line.

Preview: https://file.rdu.redhat.com/~ahoffer/2024/main-storage-terms.html#_word_usage

@bergerhoffer bergerhoffer mentioned this pull request Feb 27, 2024
Closed
@bergerhoffer bergerhoffer added the Glossary entry Topics that add or modify glossary entries label Feb 27, 2024
@bergerhoffer
Copy link
Collaborator Author

Addressed peer review feedback in #335. Also added the vale-ignore tag, properly alphabetized a few of the entries, and fixed some other issues I noticed.

@bergerhoffer bergerhoffer force-pushed the storage-terms branch 2 times, most recently from 096840c to f0321cc Compare February 27, 2024 16:15
@bergerhoffer
Copy link
Collaborator Author

@mportman12 @bburt-rh @redhat-documentation/ccs-style-council This is ready for re-review (originated from PR #335).

rolfedh
rolfedh previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM along with the changes you've indicated in the open conversations.

dfitzmau
dfitzmau previously approved these changes Feb 28, 2024
View reviewed changes
@bergerhoffer
Copy link
Collaborator Author

Addressed some of the formatting issues, left some of the more technical ones alone. Ready for more re-reviews please!

rolfedh
rolfedh previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergerhoffer bergerhoffer dismissed stale reviews from rolfedh and dfitzmau via 3fc7dd1 March 1, 2024 14:31
@bergerhoffer bergerhoffer force-pushed the storage-terms branch 2 times, most recently from d7c4ef3 to 3fc7dd1 Compare March 1, 2024 14:32
@bergerhoffer
Copy link
Collaborator Author

My pushes aren't showing up yet (maybe a GitHub outage going on?), but I removed the client side and cloud because those are already in the ISG. We actually removed them in August for this reason. Also resolved conflicts.

@bergerhoffer
Copy link
Collaborator Author

Nevermind, the pushes are here now 🎉

dfitzmau
dfitzmau reviewed Mar 20, 2024
View reviewed changes
supplementary_style_guide/glossary_terms_conventions/general_conventions/b.adoc Outdated Show resolved Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/b.adoc Outdated Show resolved Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/a.adoc Show resolved Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/b.adoc Outdated Show resolved Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/b.adoc Outdated Show resolved Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/b.adoc Outdated Show resolved Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/c.adoc Outdated Show resolved Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/d.adoc Outdated Show resolved Hide resolved
@bergerhoffer bergerhoffer mentioned this pull request Mar 21, 2024
Merged
@bergerhoffer bergerhoffer force-pushed the storage-terms branch 2 times, most recently from 34b02b7 to b1860a0 Compare March 21, 2024 18:25
@bergerhoffer
Copy link
Collaborator Author

@dfitzmau and all - updated per feedback and made the change to use {nbsp} in all entries. Please take another look when you can!

rolfedh
rolfedh approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved.

bburt-rh
bburt-rh approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@bburt-rh bburt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bburt-rh bburt-rh merged commit 4042800 into redhat-documentation:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laubai laubai laubai left review comments

@lpettyjo lpettyjo lpettyjo left review comments

@rolfedh rolfedh rolfedh approved these changes

@dfitzmau dfitzmau dfitzmau approved these changes

@bburt-rh bburt-rh bburt-rh approved these changes

Assignees
No one assigned
Labels
Glossary entry Topics that add or modify glossary entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bergerhoffer @rolfedh @laubai @dfitzmau @lpettyjo @bburt-rh