Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import var perf improvements #4813

Merged
merged 5 commits into from
Feb 13, 2025
Merged

import var perf improvements #4813

merged 5 commits into from
Feb 13, 2025

Conversation

adhami3310
Copy link
Member

apparently slice is ever so slightly faster than partition

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4813 will improve performances by 3.16%

Comparing import-var-perf-improvements (6f6c33c) with main (d79366d)

Summary

⚡ 1 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_get_all_imports[_simple_page] 489.8 µs 474.8 µs +3.16%

@adhami3310 adhami3310 merged commit b44bbc8 into main Feb 13, 2025
43 checks passed
@adhami3310 adhami3310 deleted the import-var-perf-improvements branch February 13, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alek99 Alek99 Alek99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhami3310 @Alek99