Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import var perf improvements #4813

Merged
merged 5 commits into from
Feb 13, 2025
Merged

import var perf improvements #4813

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63636c1
import var perf improvements
adhami3310 Feb 13, 2025
4b07490
use tuples over iterator
adhami3310 Feb 13, 2025
ec2e00e
the only thing that matters
adhami3310 Feb 13, 2025
df99ab6
maybe tuple map is faster than tuple list comprehension
adhami3310 Feb 13, 2025
6f6c33c
do it in one list comprehension
adhami3310 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions reflex/components/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,7 @@
)
from reflex.style import Style, format_as_emotion
from reflex.utils import format, imports, types
from reflex.utils.imports import (
ImmutableParsedImportDict,
ImportDict,
ImportVar,
ParsedImportDict,
parse_imports,
)
from reflex.utils.imports import ImportDict, ImportVar, ParsedImportDict, parse_imports
from reflex.vars import VarData
from reflex.vars.base import (
CachedVarOperation,
Expand Down Expand Up @@ -1208,7 +1202,7 @@ def _should_transpile(self, dep: str | None) -> bool:
Returns:
True if the dependency should be transpiled.
"""
return (
return bool(self.transpile_packages) and (
dep in self.transpile_packages
or format.format_library_name(dep or "") in self.transpile_packages
)
Expand Down Expand Up @@ -1291,9 +1285,10 @@ def _get_imports(self) -> ParsedImportDict:
event_imports = Imports.EVENTS if self.event_triggers else {}

# Collect imports from Vars used directly by this component.
var_datas = [var._get_all_var_data() for var in self._get_vars()]
var_imports: List[ImmutableParsedImportDict] = [
var_data.imports for var_data in var_datas if var_data is not None
var_imports = [
var_data.imports
for var in self._get_vars()
if (var_data := var._get_all_var_data()) is not None
]

added_import_dicts: list[ParsedImportDict] = []
Expand Down