Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commands] add contribution types #106

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

lunaroyster
Copy link
Contributor

@lunaroyster lunaroyster commented Nov 6, 2023

Why

The 'contributions' array is typed to take in any string, when in reality only 4 strings are currently accepted (and all others are no-ops)

What changed

  • Added ContributionType enum, made use of it everywhere

@lunaroyster
Copy link
Contributor Author

lunaroyster commented Nov 6, 2023

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@lunaroyster lunaroyster merged commit 5f0d77f into main Nov 6, 2023
4 checks passed
@lunaroyster lunaroyster deleted the 11-06-_commands_add_contribution_types branch November 6, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant