[commands] provide command args directly

[lunaroyster]

Why?

Currently, we make you wrap every single command, even nested ones. The invocation looks like

await replit.experimental.commands.add(
  { id: "hey", contributions: ["commandbar"] },
  Command({
    label: "hey",
    description: "hey commands",
    commands: () => {
      return [
        Command({
          label: "hello",
          description: "says hello",
          run: () => console.log("hello"),
        }),
        Command({
          label: "hola",
          description: "says hola",
          run: () => console.log("hola"),
        }),
      ];
    },
  }),
);

It would be nice to not have to wrap things in Command(). The client library can simply do it for you.

await replit.experimental.commands.add(
  { id: "hey", contributions: ["commandbar"] },
  {
    label: "hey",
    description: "hey commands",
    commands: () => {
      return [
        {
          label: "hello",
          description: "says hello",
          run: () => console.log("hello"),
        },
        {
          label: "hola",
          description: "says hola",
          run: () => console.log("hola"),
        },
      ];
    },
  },
);

I didn't remove Command() because I think it's actually a good pattern for composing larger commands. Also, backwards compatibility!

let hola = Command({
  label: "hola",
  description: "says hola",
  run: () => console.log("hola"),
});

let hello = Command({
  label: "hello",
  description: "says hello",
  run: () => console.log("hello"),
});

await replit.experimental.commands.add(
  { id: "hey", contributions: ["commandbar"] },
  {
    label: "hey",
    description: "hey commands",
    commands: () => {
      return [hola, hello];
    },
  },
);

What changed

• Now the add, and the old register / registerCreate methods all accept raw objects in addition to the wrapped Command(...). When you don't wrap your command objects, we do it for you
• To accomplish this, we attach a {[CommandSymbol]: true} once we wrap, just to make sure we're not doing it twice
• Beyond that, not a lot has changed. We had to update a bunch of types to reflect this new world

Test plan

• clone this repo as a repl
• hit run
• load locally via extensions devtools
• now open the chrome dev tools console, and paste in the second code snippet. you should now see a command called hey in the commandbar, which returns hello and hola

[lunaroyster]

Current dependencies on/for this PR:

• main:
  • PR [commands] provide command args directly #107 👈

This comment was autogenerated by Freephite.

[lafkpages]

Does this mean we no longer have to wrap commands in replit.proxy()?

[lunaroyster]

Does this mean we no longer have to wrap commands in replit.proxy()?

you wouldn't have had to wrap them in proxy even before this version. the first example here is the old invocation, which contains a Command() call, that does it for you

But after this merges, you don't even have to wrap them in Command(), we do that for you too

The docs will make it clearer

[lunaroyster]

@masad-frost this handles the remaining piece of feedback you had about the commands API

i'm merging this for now so i can go publish some updated docs, but would still appreciate a review, both on the code and the final syntax :)