Added fake image response #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awtkns
approved these changes
Dec 31, 2024
sdk/harambe/handlers.py
Outdated
| if ( | ||
| resource_type in ["image", "media", "font"] | ||
| if resource_type in ["image", "media"]: | ||
| fake_img = "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=" |
There was a problem hiding this comment.
Since this is constant may aswell store the b64 version of this. I would put it at the top as FAKE_1x1_img
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -74,13 +78,15 @@ def captured_url(self) -> str | None: | |||
| return self._new_pages[0] if self._new_pages else None | |||
|
|
|||
|
|
|||
| class UnnecessaryResourceHandler(AbstractHandler): | |||
| class UnnecessaryResourceHandler: | |||
There was a problem hiding this comment.
UnnecessaryResourceHandler should inherit from AbstractHandler to maintain consistency and ensure it follows the expected interface for handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add fake image response for
imageandmediaresources inUnnecessaryResourceHandlerand updateharambe-coreandharambe-sdkto version0.59.0.UnnecessaryResourceHandlerinhandlers.pynow returns a fake image forimageandmediaresource types using a base64 encoded PNG.harambe-coreandharambe-sdkversions to0.59.0inpyproject.tomlanduv.lock.harambe_coredependency insdk/pyproject.tomlto0.59.0.This description was created by
for be9b650. It will automatically update as commits are pushed.