Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fake image response #105

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Added fake image response #105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f49a63
Added fake image response
kunwar-reworkd Dec 31, 2024
46791c4
moved to constant
kunwar-reworkd Jan 2, 2025
be9b650
Fixed formatting
kunwar-reworkd Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "harambe-core"
version = "0.58.0"
version = "0.59.0"
description = "Core types for harambe SDK 🐒🍌"
authors = [
{ name = "Adam Watkins", email = "[email protected]" }
Expand Down
2 changes: 1 addition & 1 deletion core/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions sdk/harambe/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import re
import base64
from abc import ABC
from typing import Any, Literal, Self

Expand Down Expand Up @@ -78,9 +79,14 @@ class UnnecessaryResourceHandler(AbstractHandler):
async def handle(self, route: Route) -> None:
resource_type = route.request.resource_type
url = route.request.url

if (
resource_type in ["image", "media", "font"]
if resource_type in ["image", "media"]:
fake_img = "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is constant may aswell store the b64 version of this. I would put it at the top as FAKE_1x1_img

await route.fulfill(
body=base64.b64decode(fake_img), content_type="image/png"
)
return
elif (
resource_type == "font"
or re.match(r"^data:(image|audio|video)", url)
or re.match(r"social-widget|tracking-script|ads", url)
):
Expand Down
4 changes: 2 additions & 2 deletions sdk/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[project]
name = "harambe-sdk"
version = "0.58.0"
version = "0.59.0"
description = "Data extraction SDK for Playwright 🐒🍌"
authors = [
{ name = "Adam Watkins", email = "[email protected]" }
]
requires-python = ">=3.11,<4.0"
readme = "README.md"
dependencies = [
"harambe_core==0.58.0",
"harambe_core==0.59.0",
"playwright==1.47.0",
"beautifulsoup4==4.12.3",
"requests==2.32.3",
Expand Down
4 changes: 2 additions & 2 deletions sdk/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading