performance: Update based on ARC review #86
Conversation
src/srvgrp-performance.adoc
Outdated
| @@ -734,7 +734,15 @@ performance domain in the system. | |||
|
|
|||
| ==== Service: PERF_SET_LIMIT (SERVICE_ID: 0x08) | |||
| This service is used to set the performance limit of a specific | |||
| performance domain in the system. | |||
| performance domain in the system. Any subsequent calls to `PERF_SET_LEVEL` | |||
| will ensure the requested performance level stays within the defined range. | |||
There was a problem hiding this comment.
"The platform must ensure that any subsequent calls to the PERF_SET_LEVEL to set performance level is within the current set limit"
| it to comply with the updated limits. If notifications are enabled, the | ||
| platform microcontroller firmware will send an appropriate notification | ||
| (e.g., `PERF_LEVEL_CHANGE`, `PERF_POWER_CHANGE`, etc.) to the | ||
| application processor. |
There was a problem hiding this comment.
This text will then require more details. If the the new limit is NEW_LEVEL_MIN, NEW_LEVEL_MAX. Then what will be the NEW_LEVEL if the CURRENT_LEVEL < NEW_LEVEL_MIN and what will the NEW_LEVEL if the CURRENT_LEVEL > NEW_LEVEL_MAX.
Ideally NEW_LEVEL == NEW_LEVEL_MIN if the CURRENT_LEVEL < NEW_LEVEL_MIN
and
NEW_LEVEL == NEW_LEVEL_MAX if the CURRENT_LEVEL > MEW_LEVEL_MAX.
and NEW_LEVEL == CURRENT_LEVEL if its already within the range.
In some form this behaviour can be mentioned here.
- Fix rate_limit to transition_latency - Add more descriptions for PERF_SET_LIMIT riscv-non-isa#79 (comment) Signed-off-by: Ley Foon Tan <[email protected]>
| Examples: | ||
|
|
||
| * If the current performance level is below the new minimum limit, the platform | ||
| will set it to the new minimum limit. |
There was a problem hiding this comment.
NITs: just change will to may
| will set it to the new minimum limit. | ||
|
|
||
| * If the current performance level exceeds the new maximum limit, the platform | ||
| will set it to the new maximum limit. |
There was a problem hiding this comment.
NITs: just change will to may
There was a problem hiding this comment.
Other than that looks good and we can merge
There was a problem hiding this comment.
I will update this in my PR
#79 (comment)