Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: Update based on ARC review #86

Merged
merged 1 commit into from
Jan 9, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/srvgrp-performance.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ loop:
for (i = 0; i < list.returned; i++, num++) {
opp[num].freq = list.entry[entry_num++];
opp[num].power = list.entry[entry_num++];
opp[num].rate_limit = list.entry[entry_num++];
opp[num].transition_latency = list.entry[entry_num++];
}

/* Check if there are remaining OPP to be read */
Expand Down Expand Up @@ -734,7 +734,31 @@ performance domain in the system.

==== Service: PERF_SET_LIMIT (SERVICE_ID: 0x08)
This service is used to set the performance limit of a specific
performance domain in the system.
performance domain in the system. The platform must ensure that any subsequent
calls to `PERF_SET_LEVEL` to adjust the performance level remain within the
currently defined limits.

If the current performance level falls outside the newly defined minimum or
maximum ranges, the platform will automatically adjust it to comply with the
updated limits.

[NOTE]
====
Examples:

* If the current performance level is below the new minimum limit, the platform
will set it to the new minimum limit.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NITs: just change will to may


* If the current performance level exceeds the new maximum limit, the platform
will set it to the new maximum limit.
Copy link
Collaborator

@pathakraul pathakraul Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NITs: just change will to may

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that looks good and we can merge

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update this in my PR


* No adjustment is required if the current performance level is within the new
limits.
====

If notifications are enabled, the platform will send an appropriate
notification (e.g., `PERF_LEVEL_CHANGE`, `PERF_POWER_CHANGE`, etc.) to the
application processor.
Copy link
Collaborator

@pathakraul pathakraul Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text will then require more details. If the the new limit is NEW_LEVEL_MIN, NEW_LEVEL_MAX. Then what will be the NEW_LEVEL if the CURRENT_LEVEL < NEW_LEVEL_MIN and what will the NEW_LEVEL if the CURRENT_LEVEL > NEW_LEVEL_MAX.

Ideally NEW_LEVEL == NEW_LEVEL_MIN if the CURRENT_LEVEL < NEW_LEVEL_MIN
and
NEW_LEVEL == NEW_LEVEL_MAX if the CURRENT_LEVEL > MEW_LEVEL_MAX.

and NEW_LEVEL == CURRENT_LEVEL if its already within the range.

In some form this behaviour can be mentioned here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay


[#table_perf_setlimit_request_data]
.Request Data
Expand Down
Loading