Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params struct refactor #24

Merged
merged 6 commits into from
May 4, 2024
Merged

Params struct refactor #24

merged 6 commits into from
May 4, 2024

Conversation

dfbakin
Copy link
Member

@dfbakin dfbakin commented Mar 8, 2024

Test

Main changes

  • CameraIntrinsicParameters structure reworked for cleaner code and better functionality
  • Intrinsic params file idea changed (see below)
  • Changed to support multiple sets of params for cameras by their ID
  • Added tests for camera package: minimal read/write YAML coverage
  • Shortened launch of camera node: intrinsics are read by CameraIntrinsicParameters only from special file (see below)

OLD VERSION:

image_size: [1920, 1080]
camera_matrix: [0, 0, 1, 0, -2, 0, 3, 0, 3]
distortion_coefs: [1, 2, 3, 4, 5]

NEW VERSION (rotation and translation are from "world" to "camera")

parameters:
  1:
    image_size: [1920, 1080]
    camera_matrix: [0, 0, 1, 0, -2, 0, 3, 0, 3]
    distortion_coefs: [1, 2, 3, 4, 5]
    rotation: [1, 2, 3]
    translation: [1, 2, 3]
  2:
    image_size: [1920, 1080]
    camera_matrix: [42, 0, 1, 0.4242, -2, 0, 3, 0, 3]
    distortion_coefs: [1, 2, 3, 4, 5]
    rotation: [1, 2, 3]
    translation: [1, 2, 3]

@dfbakin dfbakin added the refactoring Codestyle / minor changes label Mar 8, 2024
@dfbakin dfbakin requested a review from dasimagin March 8, 2024 00:36
@dfbakin dfbakin self-assigned this Mar 8, 2024
@dfbakin dfbakin added the enhancement New feature or request label Mar 9, 2024
@dfbakin dfbakin marked this pull request as draft March 12, 2024 09:41
@dfbakin dfbakin marked this pull request as ready for review March 23, 2024 17:55
@dfbakin dfbakin mentioned this pull request Apr 1, 2024
@dfbakin dfbakin marked this pull request as draft April 13, 2024 18:00
@dfbakin dfbakin marked this pull request as ready for review April 13, 2024 23:26
This was referenced May 2, 2024
dfbakin added 6 commits May 5, 2024 01:36
feat: added tests for intrinsic params struct
fix: minor codestyle

fix: headers in camera/test/main.cpp reordered

fix: minor codestyle fix
feat: added tests fore new static mehods
fix: params tests - corrected length of distort coefs

fix: codestyle
@dfbakin dfbakin force-pushed the params-refactor branch from 509b3cd to 3b681df Compare May 4, 2024 22:38
@dfbakin dfbakin removed the request for review from dasimagin May 4, 2024 22:43
@dfbakin dfbakin merged commit 22d3caa into master May 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Codestyle / minor changes
Development

Successfully merging this pull request may close these issues.

1 participant