refactor: uses lowercased addresses to interact with the server #674

itofarina · 2021-05-07T20:41:57Z

Sends and expects lowercased addresses when interacting with the server
Applies checksum format for all addresses that are shown to users

- and process them as lowercased as well

itofarina · 2021-05-12T13:10:01Z

src/common/common.js

+   * @param {string} address
+   * @param {string} network
+   */
+  toChecksumAddressIfNeeded(address, network) {


This function should receive the networkId that would be used to apply checksum format

itofarina · 2021-05-12T13:11:07Z

src/pages/wallet/transaction.js

    } = this.state;

+    const fromChecksum = common.toChecksumAddressIfNeeded(from, chain);


We only have the chain name here, would be best to get and send networkId for checksum format check

itofarina changed the title ~~WIP - lowercasing addresses to match server~~ refactor: uses lowercased addresses to interact with the server May 11, 2021

refactor: uses lowercased addresses to interact with the server

75e778a

- and process them as lowercased as well

itofarina force-pushed the refactor/lowercaseAddresses branch from ae83631 to 75e778a Compare May 11, 2021 20:26

itofarina added 3 commits May 11, 2021 17:58

refactor: fixes !== operator

a1b69bc

feat: adds utility function to checksum only rootstock addresses

d329748

fix: checksums addresses on transaction view

08fe4be

itofarina commented May 12, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: uses lowercased addresses to interact with the server #674

refactor: uses lowercased addresses to interact with the server #674

itofarina commented May 7, 2021 •

edited

Loading

itofarina May 12, 2021

itofarina May 12, 2021

		} = this.state;

		const fromChecksum = common.toChecksumAddressIfNeeded(from, chain);

refactor: uses lowercased addresses to interact with the server #674

Are you sure you want to change the base?

refactor: uses lowercased addresses to interact with the server #674

Conversation

itofarina commented May 7, 2021 • edited Loading

itofarina May 12, 2021

Choose a reason for hiding this comment

itofarina May 12, 2021

Choose a reason for hiding this comment

itofarina commented May 7, 2021 •

edited

Loading