This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
refactor: uses lowercased addresses to interact with the server #674
Draft
itofarina
wants to merge
4
commits into
master
Choose a base branch
from
refactor/lowercaseAddresses
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
75e778a
refactor: uses lowercased addresses to interact with the server
itofarina a1b69bc
refactor: fixes !== operator
itofarina d329748
feat: adds utility function to checksum only rootstock addresses
itofarina 08fe4be
fix: checksums addresses on transaction view
itofarina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,6 +130,7 @@ class Transaction extends Component { | |
isRefreshing: false, | ||
from, | ||
to, | ||
chain, | ||
}; | ||
} | ||
|
||
|
@@ -199,9 +200,12 @@ class Transaction extends Component { | |
render() { | ||
const { navigation } = this.props; | ||
const { | ||
transactionState, transactionId, amount, dateTime, memo, confirmations, title, stateIcon, isRefreshing, from, to, | ||
transactionState, transactionId, amount, dateTime, memo, confirmations, title, stateIcon, isRefreshing, from, to, chain, | ||
} = this.state; | ||
|
||
const fromChecksum = common.toChecksumAddressIfNeeded(from, chain); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We only have the chain name here, would be best to get and send networkId for checksum format check |
||
const toChecksum = common.toChecksumAddressIfNeeded(to, chain); | ||
|
||
const txStateText = strings(`txState.${transactionState}`); | ||
|
||
const refreshControl = ( | ||
|
@@ -237,14 +241,14 @@ class Transaction extends Component { | |
<View style={styles.sectionContainer}> | ||
<Loc style={[styles.sectionTitle]} text="page.wallet.transaction.from" /> | ||
<TouchableOpacity style={[styles.copyView]} onPress={this.onFromPress}> | ||
<Text style={[styles.copyText]}>{from}</Text> | ||
<Text style={[styles.copyText]}>{fromChecksum}</Text> | ||
<Image style={styles.copyIcon} source={references.images.copyIcon} /> | ||
</TouchableOpacity> | ||
</View> | ||
<View style={styles.sectionContainer}> | ||
<Loc style={[styles.sectionTitle]} text="page.wallet.transaction.to" /> | ||
<TouchableOpacity style={[styles.copyView]} onPress={this.onToPress}> | ||
<Text style={[styles.copyText]}>{to}</Text> | ||
<Text style={[styles.copyText]}>{toChecksum}</Text> | ||
<Image style={styles.copyIcon} source={references.images.copyIcon} /> | ||
</TouchableOpacity> | ||
</View> | ||
|
@@ -279,6 +283,7 @@ Transaction.propTypes = { | |
navigate: PropTypes.func.isRequired, | ||
dispatch: PropTypes.func.isRequired, | ||
goBack: PropTypes.func.isRequired, | ||
// eslint-disable-next-line react/forbid-prop-types | ||
state: PropTypes.object.isRequired, | ||
}).isRequired, | ||
addNotification: PropTypes.func.isRequired, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should receive the networkId that would be used to apply checksum format