Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply sort and filter of walk_packages consistently #39498

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Apply sort and filter of walk_packages consistently #39498

wants to merge 1 commit into from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Feb 12, 2025 •
edited
Loading

Previously, the sorting and filtering is only applied in case of FileFinder. This makes it consistently applied.

Needed to make tests in #39369 pass.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 mentioned this pull request Feb 12, 2025
Open
5 tasks
@user202729 user202729 mentioned this pull request Feb 12, 2025
Open
3 tasks
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 4b24524; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tobiasdiez
tobiasdiez reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but there are a lot of time outs in the CI. Any idea what's going on?

@user202729
Copy link
Contributor Author

user202729 commented Feb 12, 2025 •
edited
Loading

Likely unknown unrelated bug, first time I see it was #39237 (comment) (another time at #39142 (comment) )

Maybe some modification in is_isomorphic implementation of GAP? Checking group isomorphism is quite a hard problem after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez left review comments

Assignees
No one assigned
Labels
s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@user202729 @tobiasdiez