Don't capture queue time for websocket requests #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancetarn
approved these changes
Mar 4, 2024
mitchh456
approved these changes
Mar 13, 2024
|
Hey y'all, thanks for fixing and merging this ❤️ Our scout graphs look so much better now. Any chance there will be a minor version bump soon to the gem that includes this? |
|
Hey @Zajn, sorry for the delay on this. We just released |
|
@jrothrock No worries, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the use of libraries such as Stimulus Reflex, which under the hood utilize Turbo Streams, we can run into issues where the queue times that we report are very inaccurate.
They appear to have the same queue time header/timestamp as when the connection was first created, and is not changed for subsequent data sent over the websocket. This leads to an ever growing queue time as long as the connection isn't terminated.