Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't capture queue time for websocket requests #494

Merged
merged 3 commits into from
Mar 27, 2024
+7 −0
Merged

Don't capture queue time for websocket requests #494

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d8373e
Don't capture queue time for requests over websocket
jrothrock Feb 28, 2024
f113066
Add comment
jrothrock Mar 1, 2024
57809b4
Check for upgrade header
jrothrock Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/scout_apm/layer_converters/request_queue_time_converter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ def record!

return unless headers

# When an application uses Turbo Streams, we capture very innaccurate queue times.
return if request_over_websocket?

raw_start = locate_timestamp
return unless raw_start

Expand All @@ -38,6 +41,10 @@ def record!

private

def request_over_websocket?
headers["Upgrade"] == "websocket"
end

# Looks through the possible headers with this data, and extracts the raw
# value of the header
# Returns nil if not found
Expand Down
Loading