Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3146): Skip requests to GitHub if scmRepo is available [2] #231

Merged

Conversation

y-oksaku
Copy link
Contributor

@y-oksaku y-oksaku commented Jul 17, 2024

Context

I would like to skip GitHub access if scmRepo is available.

screwdriver-cd/screwdriver#3146

Objective

Use scmRepo to get repository name if it is passed.

References

Prior PR: screwdriver-cd/data-schema#570
Issue: screwdriver-cd/screwdriver#3146

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Verified

This commit was signed with the committer’s verified signature.
stgraber Stéphane Graber
@y-oksaku
Copy link
Contributor Author

Tests are failed because validation does not allow to pass scmRepo.
Validation will be fixed in this PR.
screwdriver-cd/data-schema#570

@tkyi tkyi merged commit 6282ce7 into screwdriver-cd:master Jul 18, 2024
2 checks passed
@sd-buildbot
Copy link

🎉 This PR is included in version 12.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@y-oksaku y-oksaku deleted the feat-use-scmRepo-info branch July 18, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants