Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The same request to GItHub is being made repeatedly #3146

Open
y-oksaku opened this issue Jul 17, 2024 · 2 comments
Open

The same request to GItHub is being made repeatedly #3146

y-oksaku opened this issue Jul 17, 2024 · 2 comments

Comments

@y-oksaku
Copy link
Contributor

What happened:

Screwdriver API requests to GitHub to fetch repository data (permission, files, etc...).
But there are many same requests to get repository name from its id during starting build.

Thus it uses too much GitHub rate limit.

What you expected to happen:

Repository name is stored in pipelines.scmRepo column, so we can use this data to get repository name.
Indeed, scmRepo is already used in several places.

It would be better to skip requests to GitHub if scmRepo is available.
https://github.com/screwdriver-cd/scm-github/blob/dbd4ba539d5cc5871af1cca82f67959bc3a71d7d/index.js#L308-L311

How to reproduce it:

@VonnyJap
Copy link
Member

VonnyJap commented Nov 6, 2024

@y-oksaku - are we good to close this issue?

@kumada626
Copy link
Contributor

@VonnyJap I think we can close this issue. If we find another extra access, we will raise another Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants