Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use nth-of-type selector #8544

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: use nth-of-type selector #8544

merged 1 commit into from
Jan 13, 2025

Conversation

0xApotheosis
Copy link
Member

Description

Use nth-of-type over nth-child selector to "improve SSR" - but that isn't super useful for us.
The main benefit here is to make the annoying console log spew go away by replacing it with a best practice equivalent selector.

Screenshot 2025-01-13 at 14 07 13

Still target the same div:

Screenshot 2025-01-13 at 14 19 12

and toasts still look good (tripled to test rendering):

Screenshot 2025-01-13 at 14 15 23

Issue (if applicable)

QOL

Risk

Low

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

See description.

Engineering

N/A

Operations

N/A

Screenshots (if applicable)

See above.

@0xApotheosis 0xApotheosis requested a review from a team as a code owner January 13, 2025 03:23
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good, damn case and SSR

@NeOMakinG NeOMakinG merged commit c1bde24 into develop Jan 13, 2025
3 checks passed
@NeOMakinG NeOMakinG deleted the fix-nth-css branch January 13, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants