Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprioritize happy quotes without network fees #8550

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 13, 2025

Description

Does what it says on the box: pushes quotes without network fees (effectively Portals) at the end of happy quotes list.

Issue (if applicable)

closes #8143

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • Get rates for a pair where Portals is an option (i.e EVM same-chain route)
  • Notice Portals is pushed at the end of happy quotes
  • In case of errored quotes (e.g not enough native asset for gas), note Portals is before the errored ones

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

See this diff (left) vs. develop (right):

Screenshot 2025-01-13 at 13 41 05 Screenshot 2025-01-13 at 13 40 52 Screenshot 2025-01-13 at 13 40 15

@gomesalexandre gomesalexandre marked this pull request as ready for review January 13, 2025 12:44
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 13, 2025 12:44
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really elegant solution here, lets get it in

@woodenfurniture woodenfurniture merged commit bb96369 into develop Jan 14, 2025
1 check passed
@woodenfurniture woodenfurniture deleted the feat_deprioritize_quotes_no_gas branch January 14, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprioritize rates without gas fees
2 participants