Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable base on thorchain #8563

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat: enable base on thorchain #8563

merged 1 commit into from
Jan 14, 2025

Conversation

kaladinlight
Copy link
Contributor

Description

I was thinking everything would be automatically picked up, but I was incorrect. We need to add base network to thorchain things and generate new assets.

NOTE: Only ETH on Base pool is active. CBBTC and USDC are still currently staged

Issue (if applicable)

closes #8473

Risk

High Risk PRs Require 2 approvals

Low - just a new route on existing swapper

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Ensure swapping into ETH on Base works with Thorchain
  • Ensure swapping out of ETH on Base works with Thorchain

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

https://viewblock.io/thorchain/tx/a3cfacdab437769514833ee0aaa64d355d4565f90d8c18599f3b0efdf77e2ca7
eth eth- eth base

Swap out of ETH on Base currently pending. (TBD): https://viewblock.io/thorchain/tx/b0b2b34138db151b356601ac71f80f8f4ea90ab7a2fe6cdc43015abc9b052d98

@kaladinlight kaladinlight requested a review from a team as a code owner January 13, 2025 23:22
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap from BASE via THORchain: https://jam.dev/c/065d8171-5c0e-40b0-8fec-d6d4332cd389

Still pending at time of writing, but the transaction executed on chain as expected.

https://viewblock.io/thorchain/tx/1f5847b7868f8b22a0209f89e5962da70505ef07469d3dcfec7d0911144e7651

@0xApotheosis 0xApotheosis merged commit 5fcf871 into develop Jan 14, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the enable-base-thorchain branch January 14, 2025 03:24
@0xApotheosis
Copy link
Member

For posterity, the TX above eventually went through ✅

Screenshot 2025-01-14 at 15 43 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TC Base Prep / Testing
2 participants