fix: ensure receiveAddress query -> string | null #8565
Merged
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xApotheosis
commented
Jan 14, 2025
gomesalexandre
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Tested locally:
- Noticed no regressions in swapper receive addies ✅
https://jam.dev/c/38c2afc9-1b51-4949-a11b-081b912dccae
- Console spew is gone ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures the receiveAddress query does not return
undefined, which can cause issues due to the way TanStack query handles query state.Issue (if applicable)
Spotted by @NeOMakinG in #8543
Risk
Low
None
Testing
Ensure we no longer see the console warning.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)