Add funding links to package data, READMEs, and playground #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
commented
Jan 25, 2025
packages/tm-themes/index.d.ts
Outdated
| @@ -1,10 +1,27 @@ | |||
| /** https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository */ | |||
| export interface FundingInfo { | |||
There was a problem hiding this comment.
I didn't see any shared dependency for these packages, so I had to copy/paste the type definition. Let me know if there's a preferred alternative.
✅ Deploy Preview for textmate-grammars-themes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jtbandes
commented
Jan 25, 2025
packages/tm-grammars/index.js
Outdated
| @@ -3913,6 +4015,9 @@ export const injections = [ | |||
| embeddedIn: [ | |||
| 'ts-tags', | |||
| ], | |||
| funding: { | |||
| ko_fi: 26, | |||
There was a problem hiding this comment.
These numbers are due to an error in the upstream YAML file. I submitted a PR to fix: 0x00000001A/es6-string-html#66
I could consider manually excluding these for now
jtbandes
commented
Jan 25, 2025
jtbandes
changed the title
jtbandes
commented
Feb 1, 2025
| @@ -18,6 +24,7 @@ export interface GrammarInfo { | |||
| aliases?: string[] | |||
| licenseUrl?: string | |||
| license?: string | |||
| funding?: FundingLink[] | |||
There was a problem hiding this comment.
These shouldn't ever be undefined, except the custom source function for ts-tags is causing it to be undefined sometimes so I just adjusted the type definition since I wasn't sure how to fix that properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to implement the first part of shikijs/shiki#906:
/repos/{owner}/{repo}/contents/.github/FUNDING.yml/repos/{owner}/.github/contents/FUNDING.yml.fundingto GrammarInfo/ThemeInfoIf you wanted to display the same links on shiki.style, is there a better place to put the formatting code so it can be reused?
Example: