Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding links to package data, READMEs, and playground #116

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add funding links to package data, READMEs, and playground #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d2fa4c4
WIP
jtbandes Jan 25, 2025
6656c64
more
jtbandes Jan 25, 2025
99439e9
cleanup
jtbandes Jan 25, 2025
d53074f
more tweaks
jtbandes Jan 25, 2025
2fda885
Add links to playground too
jtbandes Jan 25, 2025
430a5f0
fix bold font
jtbandes Jan 25, 2025
a5124fa
fix extra whitespace
jtbandes Jan 25, 2025
54fa585
Merge branch 'main' into funding
antfu Jan 30, 2025
3602ed7
chore: update markdown format
antfu Jan 30, 2025
e586f44
Export FundingLinks rather than FundingInfo
jtbandes Feb 1, 2025
bf33b4b
Merge remote-tracking branch 'upstream/main' into funding
jtbandes Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tm-grammars/NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5301,7 +5301,7 @@ SOFTWARE.

=========================================================================================================
Files: mojo.json
License: https://raw.githubusercontent.com/modularml/mojo-syntax/main/LICENSE
License: https://raw.githubusercontent.com/modular/mojo-syntax/main/LICENSE
SPDX: MIT
---------------------------------------------------------------------------------------------------------
The MIT License
Expand Down
478 changes: 239 additions & 239 deletions packages/tm-grammars/README.md
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions packages/tm-grammars/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ export type GrammarCategory =
| 'config'
| 'lisp'

export interface FundingLink {
name: string
handle?: string
url: string
}

export interface GrammarInfo {
name: string
displayName: string
Expand All @@ -18,6 +24,7 @@ export interface GrammarInfo {
aliases?: string[]
licenseUrl?: string
license?: string
funding?: FundingLink[]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't ever be undefined, except the custom source function for ts-tags is causing it to be undefined sometimes so I just adjusted the type definition since I wasn't sure how to fix that properly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to be optional. If it's an empty array, we better remove the field to save some space of the generated file

sha: string
lastUpdate: string
embedded?: string[]
Expand Down
Loading
Loading