chore: refactor signature id and failed signatures #194
+800
−941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/refactor-signature
Open
volovyks
reviewed
Feb 12, 2025
|
note, that since the near contract also uses |
volovyks
approved these changes
Feb 13, 2025
| recovery_id: 0, | ||
| }; | ||
|
|
||
| let request_json = format!( | ||
| "'{}'", | ||
| serde_json::to_string(&json!({"request": request, "response": response})).unwrap() | ||
| serde_json::to_string(&json!({"sign_id": sign_id, "signature": signature})).unwrap() |
There was a problem hiding this comment.
Note: We have breaking changes in this PR too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignIdis now used everywhere instead of request_id. A couple things were made more efficient like no longer passing the part of sign requests around, instead we wholly pass aroundSignRequestwhich contains all the info the node needs to do signature generation.SignIdis an id agnostic of any chain, just has rawrequest_id,payloadandepsilon.SignArgsis all the info that is not present in theSignIdsuch asentropy,key_version, andpath.IndexedSignRequestis all the info from the indexer which includesSignIdandSignArgs.SignRequesthas more info that is not present on the chain but only inside the node such asparticipantsandproposer.ContractSignRequestsinceSignArgsbasically replaces it.SignatureMessagenow usesSignIdand does not sendContractSignRequestanymore since it was never used. This info is already indexed by each of the nodes so not necessary to confirm this, but the proposer and presignature id is still something that each node needs to come up with, so that is still being passed around. This is not a breaking serialization change since the messages are forward/backwards compatible as long as the field's names are unique/new which they are with this change.SignQueuefor better management of requests overall. All failed requests are put at the front of the queue as to be process immediately on the next try. Note that retrying uses the same participants, which is not ideal. In a separate PR, I'll have it so that the participants are reselected but the proposer will stay the same. This selection is deterministic where the seed for randomization isentropy + retry_count.