Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor signature id and failed signatures #194

Merged
merged 30 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
24b0a9e
Fix sign request subset & generate request
ChaoticTempest Feb 7, 2025
61e0eb7
Make sign queue take the request on protocol init
ChaoticTempest Feb 8, 2025
483d09f
Added invalid proposer error
ChaoticTempest Feb 8, 2025
ece3139
Rename for indexed_timedstamp & remove redundant fields
ChaoticTempest Feb 8, 2025
6d7f17e
Rename SignRequestIdentifier as SignId
ChaoticTempest Feb 10, 2025
73e5239
rename SignRequest to IndexedSignRequest
ChaoticTempest Feb 10, 2025
c7c3f6f
Use SignRequest instead of GenerationRequest
ChaoticTempest Feb 10, 2025
bc6c3ea
Move failed requests into SignQueue
ChaoticTempest Feb 10, 2025
954f65b
Rename indexed_timestamp to timestamp
ChaoticTempest Feb 10, 2025
8ea398f
Added sign id to SignatureMessage
ChaoticTempest Feb 11, 2025
c863ce7
Add IndexerSignArgs
ChaoticTempest Feb 11, 2025
4237345
rename gnerator_timestamp to timestamp
ChaoticTempest Feb 11, 2025
e133f1f
Remove ToPublish
ChaoticTempest Feb 11, 2025
ef37ee6
Custom SignId debug impl
ChaoticTempest Feb 11, 2025
cbbec15
Remove SignArgs from SignatureMessage
ChaoticTempest Feb 11, 2025
83d21d9
Move chain to one up
ChaoticTempest Feb 11, 2025
0b40a2a
Merge branch 'develop' of github.com:sig-net/sig-mpc into phuong/chor…
ChaoticTempest Feb 11, 2025
d127ad3
Moved GenerationError to error.rs
ChaoticTempest Feb 11, 2025
d7e2eaa
Use sign_id instead of receipt_id for logging in indexer
ChaoticTempest Feb 11, 2025
60720d1
Remove presignature returned as error
ChaoticTempest Feb 11, 2025
77fd862
Added SignQueue::expire on old sign requests
ChaoticTempest Feb 11, 2025
b3a6c6c
Removed need for SerializableScalar
ChaoticTempest Feb 11, 2025
64d6278
Remove need for SerializableAffinePoint
ChaoticTempest Feb 11, 2025
4740c9a
Renamed SignatureRequest to SignRequestPending
ChaoticTempest Feb 12, 2025
fdd4767
Rename ContractSignatureRequest to ContractSignRequest
ChaoticTempest Feb 12, 2025
92691b4
Added primitives crate
ChaoticTempest Feb 12, 2025
f12d8f9
Made SignId just be request_id & SignArgs contains else
ChaoticTempest Feb 12, 2025
869bf0c
moved SignId & SignArgs into primitives crate
ChaoticTempest Feb 12, 2025
7750422
Use SignId for contract requests
ChaoticTempest Feb 13, 2025
bfea101
Merge branch 'develop' of github.com:sig-net/sig-mpc into phuong/chor…
ChaoticTempest Feb 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions API.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ pub struct SignRequest {
pub key_version: u32,
}

pub struct SignatureResponse {
pub big_r: SerializableAffinePoint,
pub s: SerializableScalar,
pub struct Signature {
pub big_r: AffinePoint,
pub s: Scalar,
pub recovery_id: u8,
}
```
Expand Down Expand Up @@ -57,7 +57,7 @@ For more details check `User contract API` impl block in the [chain-signatures/c
1. Mainnet: `v1.signer`
2. Testnet: `v1.sigenr-prod.testnet`

# Interact using NEAR CLI
# Interact using NEAR CLI

There is an `Example Commands` in the [chain-signatures/contract/example.md](./chain-signature/contract/EXAMPLE.md) file.

Expand Down
24 changes: 21 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ members = [
"chain-signatures/contract",
"chain-signatures/keys",
"chain-signatures/node",
"chain-signatures/primitives",

"integration-tests",
]
Expand All @@ -16,6 +17,7 @@ version = "1.0.0"
anyhow = { version = "1.0.95", features = ["backtrace"] }
borsh = "1.5.3"
cait-sith = { git = "https://github.com/sig-net/cait-sith", rev = "9f34e8c", features = ["k256"] }
ciborium = "0.2.2"
clap = { version = "4.5.4", features = ["derive", "env"] }
deadpool-redis = "0.18.0"
hex = "0.4.3"
Expand All @@ -30,6 +32,7 @@ k256 = { version = "0.13.1", features = [
rand = "0.8.5"
reqwest = { version = "0.11.16", features = ["blocking", "json"] }
serde = { version = "1", features = ["derive"] }
serde_bytes = "0.11.15"
serde_json = "1"
sha3 = "0.10.8"
thiserror = "1"
Expand All @@ -40,12 +43,14 @@ url = { version = "2.4.0", features = ["serde"] }
web3 = "0.19.0"

near-account-id = "1.0.0"
near-primitives = "0.26.0"
near-sdk = { version = "5.6.0", features = ["legacy", "unit-testing", "unstable"] }

mpc-contract = { path = "./chain-signatures/contract" }
mpc-crypto = { path = "./chain-signatures/crypto" }
mpc-keys = { path = "./chain-signatures/keys" }
mpc-node = { path = "./chain-signatures/node" }
mpc-primitives = { path = "./chain-signatures/primitives" }

[patch.crates-io]
# TODO: trigger Cargo.lock update for x25519-dalek once they release.
Expand Down
1 change: 1 addition & 0 deletions chain-signatures/contract/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ crate-type = ["cdylib", "lib"]
borsh.workspace = true
k256.workspace = true
mpc-crypto.workspace = true
mpc-primitives.workspace = true
near-sdk.workspace = true
serde.workspace = true
serde_json.workspace = true
Expand Down
Loading
Loading