-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SingleAttestation
full implementation
#6616
Open
eserilev
wants to merge
12
commits into
sigp:unstable
Choose a base branch
from
eserilev:single-attestation-refactor
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngle_attestation_electra
3 tasks
SingleAttestation
refactorSingleAttestation
full implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
code-quality
electra
Required for the Electra/Prague fork
work-in-progress
PR is a work-in-progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #6380
This is the "full" implementation of the new
SingleAttestation
changes. Theres probably no need to merge this in before Electra assuming that #6488 is sufficient for making us fully spec compliantThis also implements the new submit attestation v2 endpoint ethereum/beacon-APIs#472
We'll also want to eventually want to yank out all the unaggregated attestation logic so that both the
GossipAttestation
andGossipSingleAttestation
flows are unified. I might handle that in this PR, or in a subsequent PR depending on feedback from the rest of the team.