Mzml writer now rounds to 4 decimal places #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 77.42% 77.42%
=======================================
Files 223 223
Lines 33213 33213
Branches 3431 3431
=======================================
Hits 25714 25714
Misses 6932 6932
Partials 567 567
|
nbollis
approved these changes
Jan 17, 2025
| @@ -135,7 +136,8 @@ public void TestWriting(string filePath, string outfile, int loop) | |||
| Assert.That(readInScan.OneBasedScanNumber.Equals(writtenScan.OneBasedScanNumber)); | |||
| Assert.That(readInScan.MsnOrder.Equals(writtenScan.MsnOrder)); | |||
| Assert.That(readInScan.IsCentroid.Equals(writtenScan.IsCentroid)); | |||
| Assert.That(readInScan.MassSpectrum.Equals(writtenScan.MassSpectrum)); | |||
There was a problem hiding this comment.
Should use CollectionAssert.IsEqualsTo() to if you want an exact match of each element. It is also much faster
trishorts
approved these changes
Jan 17, 2025
zhuoxinshi
approved these changes
Jan 18, 2025
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing mzMLs, we round the m/z values to 4 decimal places