Set poetry version to 1.8.5
#1543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
commented
Jan 8, 2025
| @@ -32,7 +32,6 @@ jobs: | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install poetry | |||
| poetry config installer.modern-installation false | |||
There was a problem hiding this comment.
note: This poetry installer config was added in https://github.com/software-mansion/starknet.py/pull/881/files, but it looks like we don't need it anymore, thanks to python-poetry/poetry#9392
Below is part of Poetry 2.0.0 changelog 👇
franciszekjob
commented
Jan 8, 2025
Comment on lines
-49
to
+48
| poetry lock --check | ||
| poetry check --lock |
There was a problem hiding this comment.
note: poetry lock --check is deprecated, we should use poetry check --lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Before, our CI used latests version of Poetry. This PR changes it to be fixed 1.8.5.
Recently there has been release of Poetry 2.0.0, which bumped minimal version of Python from 3.8 to 3.9. ATM, starknet.py uses >=3.8, <3.13, hence the need of using Poetry older than 2.0.0
Without this change, CI is failing, here's an example run.