Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set poetry version to 1.8.5 #1543

Closed
wants to merge 8 commits into from
+8 −50
Closed

Set poetry version to 1.8.5 #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8ba7be9
Set poetry version to `1.8.5`
franciszekjob Jan 8, 2025
d8cab89
Temporarily bring back poetry to latest version
franciszekjob Jan 8, 2025
07c893c
Revert "Temporarily bring back poetry to latest version"
franciszekjob Jan 8, 2025
f247f21
Use latest poetry; Require python >= 3.9
franciszekjob Jan 8, 2025
777db98
Run `poetry lock --no-update`
franciszekjob Jan 8, 2025
d57748f
Remove poetry configuration of `modern-installation`
franciszekjob Jan 8, 2025
b4833c9
Add `poetry self add poetry-plugin-export` in docs workflow
franciszekjob Jan 8, 2025
76e36ea
Update migration guide
franciszekjob Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install poetry
poetry config installer.modern-installation false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This poetry installer config was added in https://github.com/software-mansion/starknet.py/pull/881/files, but it looks like we don't need it anymore, thanks to python-poetry/poetry#9392

Below is part of Poetry 2.0.0 changelog 👇
image


- name: Set up Python 3.12
uses: actions/setup-python@v4
Expand All @@ -46,7 +45,7 @@ jobs:

- name: Check poetry.lock
run: |
poetry lock --check
poetry check --lock
Comment on lines -49 to +48
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: poetry lock --check is deprecated, we should use poetry check --lock


- name: Lint
run: |
Expand Down Expand Up @@ -85,7 +84,6 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install poetry
poetry config installer.modern-installation false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down Expand Up @@ -166,7 +164,6 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install poetry
poetry config installer.modern-installation false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down Expand Up @@ -278,7 +275,6 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install poetry
poetry config installer.modern-installation false

- name: Set up Python 3.12
uses: actions/setup-python@v4
Expand Down Expand Up @@ -365,7 +361,6 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install poetry
poetry config installer.modern-installation false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down Expand Up @@ -427,7 +422,6 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install poetry
poetry config installer.modern-installation false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down Expand Up @@ -494,7 +488,6 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install poetry
poetry config installer.modern-installation false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down
1 change: 1 addition & 0 deletions .readthedocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ build:
jobs:
pre_install:
- pip install poetry
- poetry self add poetry-plugin-export
- poetry export -f requirements.txt --output requirements.txt --without-hashes -E docs -E ledger

sphinx:
Expand Down
2 changes: 2 additions & 0 deletions docs/migration_guide.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Migration guide
[unreleased] Migration guide
******************************

This version of starknet.py requires Python 3.9 as a minimum version.

[unreleased] Minor changes
--------------------------

Expand Down
44 changes: 3 additions & 41 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ repository = "https://github.com/software-mansion/starknet.py"
documentation = "https://starknetpy.rtfd.io/"

[tool.poetry.dependencies]
python = ">=3.8, <3.13"
python = ">=3.9, <3.13"
asgiref = "^3.4.1"
marshmallow = "^3.15.0"
marshmallow-oneofschema = "3.1.1"
Expand Down
Loading