Optimize CI #1553
Merged
Optimize CI #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
commented
Jan 13, 2025
There was a problem hiding this comment.
note: The initial value of balance is 1777 when the contract is deployed. Previously, we assumed it was 1897, as other tests modified the balance value. This made the tests interdependent, relying on changes made by other tests. Now they use separate contract, ultimately enabling parallel execution.
There was a problem hiding this comment.
I don't really think this test was meant to check storage after increasing balance - if so, we can easily add a test for invoke + check storage. However, then this is more a test for contract itself, not for our API.
….com/software-mansion/starknet.py into franciszekjob/optimize-running-tests
franciszekjob
commented
Jan 14, 2025
ddoktorski
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
-n autoflag when running tests withpytest, which will spawn a number of workers processes equal to the number of available CPUs, and distribute the tests randomly across them, docs referencetest_call_contractandtest_get_storage_atpreviously used a contract shared across other tests. This PR adjusts them, so they use a separate contract, i.e. they are not influenced by other testsComparison (Linux)
Before: ~13/14 minutes
Now: ~7/8 minutes