-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize CI #1553
Merged
franciszekjob
merged 10 commits into
development
from
franciszekjob/optimize-running-tests
Jan 21, 2025
Merged
Optimize CI #1553
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a06f157
Use `-n auto` when running tests
franciszekjob 0aef095
Refactor `test_call_contract` and `test_get_storage_at` tests
franciszekjob 53718ca
Add Docker speculos image caching
franciszekjob 3e09e1c
Add saving cache step
franciszekjob 751c333
Trigger CI
franciszekjob 87c6987
Merge branch 'development' into franciszekjob/optimize-running-tests
franciszekjob f304295
Update step name; Update image file name
franciszekjob 21e6f21
Merge branch 'franciszekjob/optimize-running-tests' of https://github…
franciszekjob f14f72a
Remove caching speculos image
franciszekjob e429c04
Add comment with explanation of adding `contract_address_2`
franciszekjob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: The initial value of
balance
is1777
when the contract is deployed. Previously, we assumed it was1897
, as other tests modified thebalance
value. This made the tests interdependent, relying on changes made by other tests. Now they use separate contract, ultimately enabling parallel execution.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really think this test was meant to check storage after increasing balance - if so, we can easily add a test for invoke + check storage. However, then this is more a test for contract itself, not for our API.