Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile hardware - Draft Hardware Profile Submission #947

Merged
merged 141 commits into from
Jan 22, 2025
Merged

Profile hardware - Draft Hardware Profile Submission #947

merged 141 commits into from
Jan 22, 2025

Conversation

stevenc-stb
Copy link

This is the draft hardware submission. Please review and advise.

@stevenc-stb
Add Process Obect for HBOM
75be2c5 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Add files via upload
b111d39 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Add Hardware Class Profile
f7b92b0 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update Hardware.md
cdc9d0b 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update and rename xAxis.md to xAxisLength.md
a9c466c 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update and rename yAxis.md to yAxisLength.md
aee5e70 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update and rename zAxis.md to zAxisLength.md
b6d82c6 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update HBOMDimensions.md - Change ()Axis to ()AxisLength
6f33d08 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update HBOMDimensions.md Fix Capulization
4165756 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Delete model/Hardware/Vocabularies/processType.md
2c56078 
Need to move to model/Core/Vocabularies/processType.md

Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Add processType to Core
9d5191e 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update Process.md
131f964 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update and rename type.md to typeOfProcess.md
f0dc396 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update Process.md
8a0bb7e 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Delete model/Hardware/Vocabularies/documentState.md
c930806 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Add Document State to the right place.
72bfbef 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update RelationshipType.md
3300866 
Add new Relationship Types 

Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update RelationshipType.md
47944eb 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update RelationshipType.md
e724862 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update physical.md
719c075 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update status.md
2c37e9b 
Improved clarity 

Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update RelationshipType.md
25ff6f6 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update informationElementList.md
00d0f4d 
Improved Clarity. 

Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update physical.md
b35b37c 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update virtualFlag.md
ce6ba53 
Clarity

Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update virtualFlag.md
5dbf526 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update coordinateOrientationType.md
e1427b2 
Fix coordinateOrientationType 

Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Delete model/Hardware/Vocabularies/processType.md
89c926c 
Moved to model/Core/Vocabularies/processType.md

Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Add files via upload
6db3db4 
move to /Core/Vocabularies/processType.md 

Signed-off-by: stevenc-stb <[email protected]>
@bact bact added the Profile:Hardware Hardware Profile and related matters label Dec 21, 2024
@stevenc-stb
Update Hardware.md
9daa0ba 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update Hardware.md
0f22a7c 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update PhysicalHardware.md
c2f80a8 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update and rename HBOMPhysical.md to HBOMMass.md
1414da8 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update VirtualHardware.md
6a60dcc 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Add files via upload
9ac9685 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Add files via upload
10d8237 
Signed-off-by: stevenc-stb <[email protected]>
bact
bact requested changes Jan 21, 2025
View reviewed changes
model/Hardware/Classes/Hardware.md Outdated Show resolved Hide resolved
model/Hardware/Classes/Hardware.md Outdated Show resolved Hide resolved
model/Core/Classes/DefinedProcess.md Outdated Show resolved Hide resolved
bact
bact requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few errors from spec-parser:

ERROR:root:In class /Hardware/Hardware, property organizationalEntity has type /Core/Organization but the range of /Hardware/organizationalEntity is /Core/Agent
ERROR:root:In class /Hardware/Hardware, property releaseDate has type /Core/DateTime but the range of /Hardware/releaseDate is Core/DateTime
ERROR:root:In class /Hardware/PhysicalHardware, property dimensions has type HBOMDimensions but the range of /Hardware/dimensions is /Hardware/HBOMDimensions

@stevenc-stb
Update Hardware.md
3687545 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update releaseDate.md
c81ff96 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update dimensions.md
ad05fe0 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb stevenc-stb requested a review from zvr January 21, 2025 17:56
bact
bact requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one error from spec-parser.
Not sure if it is related to the naming convention of the property or not.

KeyError: '/Hardware/VirtualHardwareModel'

model/Hardware/Properties/VirtualHardwareModel.md Outdated Show resolved Hide resolved
model/Hardware/Properties/VirtualHardwareModel.md Outdated Show resolved Hide resolved
stevenc-stb and others added 4 commits January 21, 2025 12:11
@stevenc-stb @bact
Apply suggestions from code review
9be6aa4 
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Rename VirtualHardwareModel.md to virtualHardwareModel.md
640cd60 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update VirtualHardware.md
3823315 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb
Update virtualHardwareModel.md
adb3157 
Signed-off-by: stevenc-stb <[email protected]>
@stevenc-stb stevenc-stb requested a review from bact January 21, 2025 19:07
bact
bact approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@bact bact left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current Markdown files are now conform to the structure and format that spec-parser expected. LGTM.

My opinion is that we can use this as a base and other improvements can be discussed and being amend in additional PRs after this.

@bact bact added this to the 3.1 milestone Jan 22, 2025
@goneall
Copy link
Member

goneall commented Jan 22, 2025

I agree - we can go ahead and merge this into the profile-hardware branch - it will make it easier to review future changes.

@stevenc-stb - if you agree, I'll merge this PR.

@stevenc-stb
Copy link
Author

I agree - we can go ahead and merge this into the profile-hardware branch - it will make it easier to review future changes.

@stevenc-stb - if you agree, I'll merge this PR.

go ahead and merge it.

@goneall goneall merged commit 46f0334 into spdx:profile-hardware Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@bact bact bact approved these changes

@kestewart kestewart Awaiting requested review from kestewart

@zvr zvr Awaiting requested review from zvr

Assignees
No one assigned
Labels
Profile:Hardware Hardware Profile and related matters
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenc-stb @bact @goneall @zvr