-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile hardware - Draft Hardware Profile Submission #947
Merged
goneall
merged 141 commits into
spdx:profile-hardware
from
stevenc-stb:profile-hardware
Jan 22, 2025
Merged
Changes from 134 commits
Commits
Show all changes
141 commits
Select commit
Hold shift + click to select a range
75be2c5
Add Process Obect for HBOM
stevenc-stb b111d39
Add files via upload
stevenc-stb f7b92b0
Add Hardware Class Profile
stevenc-stb cdc9d0b
Update Hardware.md
stevenc-stb a9c466c
Update and rename xAxis.md to xAxisLength.md
stevenc-stb aee5e70
Update and rename yAxis.md to yAxisLength.md
stevenc-stb b6d82c6
Update and rename zAxis.md to zAxisLength.md
stevenc-stb 6f33d08
Update HBOMDimensions.md - Change ()Axis to ()AxisLength
stevenc-stb 4165756
Update HBOMDimensions.md Fix Capulization
stevenc-stb 2c56078
Delete model/Hardware/Vocabularies/processType.md
stevenc-stb 9d5191e
Add processType to Core
stevenc-stb 131f964
Update Process.md
stevenc-stb f0dc396
Update and rename type.md to typeOfProcess.md
stevenc-stb 8a0bb7e
Update Process.md
stevenc-stb c930806
Delete model/Hardware/Vocabularies/documentState.md
stevenc-stb 72bfbef
Add Document State to the right place.
stevenc-stb 3300866
Update RelationshipType.md
stevenc-stb 47944eb
Update RelationshipType.md
stevenc-stb e724862
Update RelationshipType.md
stevenc-stb 719c075
Update physical.md
stevenc-stb 2c37e9b
Update status.md
stevenc-stb 25ff6f6
Update RelationshipType.md
stevenc-stb 00d0f4d
Update informationElementList.md
stevenc-stb b35b37c
Update physical.md
stevenc-stb ce6ba53
Update virtualFlag.md
stevenc-stb 5dbf526
Update virtualFlag.md
stevenc-stb e1427b2
Update coordinateOrientationType.md
stevenc-stb 89c926c
Delete model/Hardware/Vocabularies/processType.md
stevenc-stb 6db3db4
Add files via upload
stevenc-stb ca45c08
Remove extra colon in informationElementList.md
bact 2adc10b
Update model/Hardware/Classes/HBOMPhysical.md
stevenc-stb 7cdb584
Update documentState.md
stevenc-stb 27ce819
Rename documentState.md to DocumentState.md
stevenc-stb f529397
Update and rename processType.md to ProcessType.md
stevenc-stb d20a189
Update Process.md
stevenc-stb ff12907
Update coordinateOrientationType.md
stevenc-stb bebfaa1
Rename coordinateOrientationType.md to CoordinateOrientationType.md
stevenc-stb a422636
Update HBOMDimensions.md
stevenc-stb 4e4f569
Update coordinateOrientation.md
stevenc-stb 96a1c83
Update status.md
stevenc-stb e074c7d
Update model/Hardware/Classes/Hardware.md
stevenc-stb 5d84b8c
Update model/Hardware/Classes/HBOMPhysical.md
stevenc-stb e74e271
Update model/Core/Vocabularies/DocumentState.md
stevenc-stb 1be8552
Update model/Hardware/Classes/HBOMDimensions.md
stevenc-stb 4d8790a
Update model/Core/Vocabularies/RelationshipType.md
stevenc-stb 5857a1d
Update Hardware.md
stevenc-stb 1182b0c
Update organizationalEntity.md
stevenc-stb 984532c
Update model/Hardware/Vocabularies/CoordinateOrientationType.md
stevenc-stb 2cf3ea2
Update model/Hardware/Vocabularies/CoordinateOrientationType.md
stevenc-stb b5233e1
Update model/Hardware/Vocabularies/CoordinateOrientationType.md
stevenc-stb 63c9dc7
Update model/Hardware/Vocabularies/CoordinateOrientationType.md
stevenc-stb 38749c4
Update organizationalEntity.md
stevenc-stb d646159
Update organizationalEntity.md
stevenc-stb 2106dad
Update Process.md
stevenc-stb e30d79e
Delete model/Core/Properties/typeOfProcess.md
stevenc-stb 7b819df
Add files via upload
stevenc-stb 1e46cc2
Rename Action.md to Action.md
stevenc-stb 9ae7466
Add files via upload
stevenc-stb 0ece0ba
Update actionEndTime.md
stevenc-stb babe10b
Update actionStartTime.md
stevenc-stb 3c89cbd
Update Hardware.md
stevenc-stb 4849e6f
Update Hardware.md
stevenc-stb 89002b4
Add files via upload
stevenc-stb d1a8ed8
Update InstantiatedProcess.md
stevenc-stb 833d5cb
Update InstantiatedProcess.md
stevenc-stb 74281a4
Update PhysicalHardware.md
stevenc-stb dab6200
Update PhysicalHardware.md
stevenc-stb 3edca57
Update PhysicalHardware.md
stevenc-stb fc8a5cd
Update VirtualHardware.md
stevenc-stb 7f6fa51
Update model/Core/Classes/Action.md
stevenc-stb a7e13d1
Update model/Core/Classes/Action.md
stevenc-stb 524e2a1
Update model/Core/Classes/Action.md
stevenc-stb 65a1c4c
Update model/Core/Classes/Action.md
stevenc-stb 72b5ec6
Update model/Core/Classes/Process.md
stevenc-stb 996dacb
Update model/Hardware/Properties/centerofMass.md
stevenc-stb 962c430
Update model/Hardware/Properties/centerofMass.md
stevenc-stb 71f79d5
Update model/Hardware/Vocabularies/CoordinateOrientationType.md
stevenc-stb 72502ed
Update model/Hardware/Hardware.md
stevenc-stb c9f84f7
Update model/Core/Properties/actionEndTime.md
stevenc-stb f154c68
Update model/Hardware/Classes/HBOMPhysical.md
stevenc-stb 0e1f9e8
Rename centerofMass.md to centerOfMass.md
stevenc-stb 32e0518
Update model/Core/Classes/Process.md
stevenc-stb 20ad96d
Update model/Core/Classes/Process.md
stevenc-stb fb64bde
Update model/Core/Classes/Process.md
stevenc-stb eb7bcef
Update model/Core/Properties/actionEndTime.md
stevenc-stb c2908ca
Update model/Core/Properties/actionEndTime.md
stevenc-stb af1d142
Update model/Core/Properties/actionStartTime.md
stevenc-stb 1521a31
Apply suggestions from code review
stevenc-stb 2e313d8
Delete model/Hardware/Properties/virtualFlag.md
stevenc-stb c55ed04
Apply suggestions from code review
stevenc-stb 4036571
Delete model/Core/Vocabularies/ProcessType.md
stevenc-stb e4ec382
Update actionEndTime.md
stevenc-stb 9831262
Update HBOMDimensions.md
stevenc-stb ba26235
Update VirtualHardware.md
stevenc-stb 032f150
Update Hardware.md
stevenc-stb 7e1ebd9
Update Hardware.md
stevenc-stb d462c9d
Update model/Hardware/Classes/HBOMPhysical.md
bact 63cbcf9
Update physical.md
stevenc-stb 06a91df
Apply suggestions from code review
stevenc-stb e08643a
Update HBOMPhysical.md
stevenc-stb 39a3b1e
Update model/Hardware/Properties/mass.md
stevenc-stb 6c4934c
Apply suggestions from code review
stevenc-stb c869ded
Update Action.md
stevenc-stb 4839548
Update Process.md
stevenc-stb b52035d
Update actionEndTime.md
stevenc-stb a852b74
Update actionStartTime.md
stevenc-stb 28b5f79
Update centerOfMass.md
stevenc-stb 049eb19
Update physical.md
stevenc-stb 8ff64b5
Remove an extra blank line in DocumentState.md
bact 906cb31
Update VirtualHardware.md
stevenc-stb 27c2b30
Update VirtualHardware.md
stevenc-stb 7995374
Update model/Hardware/Classes/InstantiatedProcess.md
bact b7edb59
Update model/Hardware/Classes/VirtualHardware.md
bact 288da09
Update model/Hardware/Classes/InstantiatedProcess.md
bact 58a9394
Update model/Hardware/Classes/VirtualHardware.md
bact 0fc7d6b
Update and rename Process.md to DefinedProcess.md
stevenc-stb 3a44a6f
Update and rename version.md to processVersion.md
stevenc-stb 1246e18
Update and rename status.md to processReadiness.md
stevenc-stb d453fcc
Update processReadiness.md
stevenc-stb 3719d97
Update and rename DocumentState.md to ProcessReadinessType.md
stevenc-stb 36108b6
Update rationale.md
stevenc-stb 0c454e8
Update InstantiatedProcess.md
stevenc-stb ed23de3
Rename InstantiatedProcess.md to InstantiationVirtualHardwareProcess.md
stevenc-stb d282cb1
Update and rename version.md to hardwareVersion.md
stevenc-stb 9daa0ba
Update Hardware.md
stevenc-stb 0f22a7c
Update Hardware.md
stevenc-stb c2f80a8
Update PhysicalHardware.md
stevenc-stb 1414da8
Update and rename HBOMPhysical.md to HBOMMass.md
stevenc-stb 6a60dcc
Update VirtualHardware.md
stevenc-stb 9ac9685
Add files via upload
stevenc-stb 10d8237
Add files via upload
stevenc-stb a4fe7bf
Update model/Core/Classes/DefinedProcess.md
bact cc06d46
Update model/Hardware/Classes/Hardware.md
bact 67d68b8
Update model/Hardware/Classes/Hardware.md
bact 3687545
Update Hardware.md
stevenc-stb c81ff96
Update releaseDate.md
stevenc-stb ad05fe0
Update dimensions.md
stevenc-stb 9be6aa4
Apply suggestions from code review
stevenc-stb 640cd60
Rename VirtualHardwareModel.md to virtualHardwareModel.md
stevenc-stb 3823315
Update VirtualHardware.md
stevenc-stb adb3157
Update virtualHardwareModel.md
stevenc-stb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# Action | ||
|
||
## Summary | ||
|
||
Class that describes an action that has occurred. | ||
|
||
## Description | ||
|
||
Action defines an event that has occurred. This is an Abstract Action. | ||
|
||
## Metadata | ||
|
||
- name: Action | ||
- SubclassOf: Artifact | ||
- Instantiability: Abstract | ||
|
||
## Properties | ||
|
||
- actionStartTime | ||
- type: DateTime | ||
- minCount: 0 | ||
- maxCount: 1 | ||
- actionEndTime | ||
- type: DateTime | ||
- minCount: 0 | ||
- maxCount: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# DefinedProcess | ||
|
||
## Summary | ||
|
||
Class that describes a process. | ||
|
||
## Description | ||
|
||
Processes are composed of systematic task(s) required to achieve a goal. | ||
|
||
## Metadata | ||
|
||
- name: DefinedProcess | ||
- SubclassOf: Artifact | ||
- Instantiability: Abstract | ||
|
||
## Properties | ||
|
||
- processVersion | ||
- type: xsd:string | ||
- minCount: 1 | ||
- maxCount: 1 | ||
- processRationale | ||
- type: xsd:string | ||
- minCount: 0 | ||
- maxCount: 1 | ||
- processReadiness | ||
- type: ProcessReadinessType | ||
- minCount: 0 | ||
- maxCount: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# actionEndTime | ||
|
||
## Summary | ||
|
||
Property that describes the time at which an action stops. | ||
|
||
## Description | ||
|
||
Property describing the time at which an action stops or finishes. | ||
|
||
## Metadata | ||
|
||
- name: actionEndTime | ||
- Nature: DataProperty | ||
- Range: DateTime |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# actionStartTime | ||
|
||
## Summary | ||
|
||
Property describing the start time of an action. | ||
|
||
## Description | ||
|
||
actionStartTime is the time at which an action is triggered. | ||
|
||
## Metadata | ||
|
||
- name: actionStartTime | ||
- Nature: DataProperty | ||
- Range: DateTime |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# processReadiness | ||
|
||
## Summary | ||
|
||
processReadiness describes the readiness of a process. | ||
|
||
## Description | ||
|
||
Draft, active, obsolete or other are used to define the readiness of a proceedure. | ||
|
||
## Metadata | ||
|
||
- name: processReadiness | ||
- Nature: DataProperty | ||
- Range: ProcessReadinessType |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# processVersion | ||
|
||
## Summary | ||
|
||
Defines the version of a specific process. | ||
|
||
## Description | ||
|
||
Defines the version of a specific process. | ||
|
||
## Metadata | ||
|
||
- name: processVersion | ||
- Nature: DataProperty | ||
- Range: xsd:string |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# processRationale | ||
|
||
## Summary | ||
|
||
The reason a process exists. | ||
|
||
## Description | ||
|
||
The reason a process exists. | ||
|
||
## Metadata | ||
|
||
- name: processRationale | ||
- Nature: DataProperty | ||
- Range: xsd:string |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# ProcessReadinessType | ||
|
||
## Summary | ||
|
||
The process Readiness is defined by the enumeration. | ||
|
||
## Description | ||
|
||
process Readiness enumerations are used to define the verson state. | ||
|
||
## Metadata | ||
|
||
- name: ProcessReadinessType | ||
|
||
## Entries | ||
|
||
- draft: in production | ||
- active: in use | ||
- obsolete: superseded or not valid at present | ||
- other: other |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# HBOMDimensions | ||
|
||
## Summary | ||
|
||
Class that describes a instance of HBOMDimensions. | ||
|
||
## Description | ||
|
||
This class records the unit dimensions. | ||
|
||
## Metadata | ||
|
||
- name: HBOMDimensions | ||
- Instantiability: Concrete | ||
|
||
## Properties | ||
|
||
- xAxisLength | ||
- type: xsd:string | ||
- minCount: 1 | ||
- maxCount: 1 | ||
- yAxisLength | ||
- type: xsd:string | ||
- minCount: 1 | ||
- maxCount: 1 | ||
- zAxisLength | ||
- type: xsd:string | ||
- minCount: 1 | ||
- maxCount: 1 | ||
- dimensionsUnit | ||
- type: xsd:string | ||
- minCount: 1 | ||
- maxCount: 1 | ||
- coordinateOrientation | ||
- type: CoordinateOrientationType | ||
- minCount: 1 | ||
- maxCount: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# HBOMMass | ||
|
||
## Summary | ||
|
||
Class that describes a instance of HBOMPhysical. | ||
|
||
## Description | ||
|
||
Describes the physical mass characteristics of hardware. | ||
|
||
## Metadata | ||
|
||
- name: HBOMMass | ||
- Instantiability: Concrete | ||
|
||
## Properties | ||
|
||
- mass | ||
- type: xsd:decimal | ||
- maxCount: 1 | ||
- massUnit | ||
- type: xsd:string | ||
- maxCount: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# Hardware | ||
|
||
## Summary | ||
|
||
Class that describes an instance of Hardware. | ||
|
||
## Description | ||
|
||
A hardware artifact is a distinct unit related to hardware. | ||
|
||
## Metadata | ||
|
||
- name: Hardware | ||
- SubclassOf: /Core/Element | ||
- Instantiability: Abstract | ||
|
||
## Properties | ||
|
||
- organizationalEntity | ||
- type: /Core/Organization | ||
- minCount: 1 | ||
- maxCount: 1 | ||
- hardwareVersion | ||
- type: xsd:string | ||
- maxCount: 1 | ||
- partNumber | ||
- type: xsd:string | ||
- minCount: 1 | ||
- maxCount: 1 | ||
- releaseDate | ||
- type: /Core/DateTime | ||
- maxCount: 1 | ||
- serialNumber | ||
- type: xsd:string | ||
- maxCount: 1 | ||
- batchNumber | ||
- type: xsd:string | ||
- maxCount: 1 | ||
- informationElementList | ||
- type: /Core/DictionaryEntry |
18 changes: 18 additions & 0 deletions
18
model/Hardware/Classes/InstantiationVirtualHardwareProcess.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# InstantiationVirtualHardwareProcess | ||
|
||
## Summary | ||
|
||
Class that describes an InstantiationVirtualHardwareProcess that is used to define VirtualHardware and its source. | ||
|
||
## Description | ||
|
||
InstantiationVirtualHardwareProcess is a class defining the process needed to instantiate an 'VirtualHardware' defined by running software package(s). | ||
|
||
## Metadata | ||
|
||
- name: InstantiationVirtualHardwareProcess | ||
- SubclassOf: /Core/DefinedProcess | ||
- Instantiability: Concrete | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# PhysicalHardware | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the difference between PhysicalHardware and HBOMPhysical ? |
||
|
||
## Summary | ||
|
||
Class that describes a physical instance of Hardware. | ||
|
||
## Description | ||
|
||
A PhysicalHardware artifact describes a distinct physical unit. | ||
|
||
## Metadata | ||
|
||
- name: PhysicalHardware | ||
- SubclassOf: Hardware | ||
- Instantiability: Concrete | ||
|
||
## Properties | ||
|
||
- massOfHardware | ||
- type: HBOMMass | ||
- minCount: 0 | ||
- maxCount: 1 | ||
- dimensions | ||
- type: HBOMDimensions | ||
- maxCount: 1 | ||
- centerOfMass | ||
- type: HBOMDimensions | ||
- maxCount: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
SPDX-License-Identifier: Community-Spec-1.0 | ||
|
||
# VirtualHardware | ||
|
||
## Summary | ||
|
||
Class that describes an instance of VirtualHardware. | ||
|
||
## Description | ||
|
||
A VirtualHardware is a distinct article related to simulation or emulation hardware. | ||
This is used to assist in recording "Digital Twinning". | ||
A FPGA simualtion of hardware is a VirtualHardware. | ||
Virtual hardware requires instantiation involving specific hardware and software. | ||
|
||
## Metadata | ||
|
||
- name: VirtualHardware | ||
- SubclassOf: Hardware | ||
- Instantiability: Concrete | ||
|
||
## Properties | ||
bact marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
bact marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- VirtualHardwareModel | ||
- type: VirtualHardwareModelType | ||
- minCount: 0 | ||
- maxCount: 1 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a separate class instead of these being properties of HBOMPhysical ?
And what does HBOM mean, anyway?