-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Change formatting of listfiles to use gersemi, remove cmake-format #2576
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
Should it possible to postpone this PR due to parallel developments? |
I will handle the merging ;) |
Gersemi seem to well handle functions with optional arguments. The result is nice even without specifying the arguments in a config file (like we did in .cmake-format.yaml). |
Yes, the author of gersemi BlankSpruce did this deliberately to simplify the parsing logic. Users just have to write their functions/macros which use I've already used @jcarpent we can wait for Pinocchio 4, sure 😃 |
to use the cmakemodules' definitions I keep forgetting to do this every single time...
303e05e
to
4b48ff8
Compare
This PR removes the abandoned cmake-format to use the maintained gersemi. It also reformats all the CMake listfiles, picking up case-sensitive definitions from the jrl-cmakemodules and other listfiles in Pinocchio.