-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-24700: Resolve CentOS 8 deprecation #212
Conversation
29e61a6
to
9944fdc
Compare
A side note: it's not clear to me why we have |
9944fdc
to
6ee7d5b
Compare
Most of the testing has been done here: |
images/stackrox-ui-test.Dockerfile
Outdated
|
||
RUN \ | ||
mv /bin/bash /bin/real-bash && \ | ||
mv /bin/bash-wrapper /bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
fcea57d
to
eeffe4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
One question but not blocking merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created stackrox/scanner#1589 to confirm Scanner v2 can still build with this image, if you want to see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scanner images LGTM, thanks
Description
Dockerfiles/Containerfiles using
quay.io/centos/centos:stream8
as the base image were breaking due to the removal ofmirrorlist.centos.org
.Example: https://github.com/stackrox/rox-ci-image/actions/runs/10011868762/job/27676182918
These changes substitute
ubi8:latest
in place ofcentos:stream8
and add another image,stackrox-ui-test
, to enable X11 support, which is required for running UI tests (particularly in OSCI).Testing
Changes have been validated here:
Other approaches
CentOS Vault mirror
This is a valid option and probably the most reasonable way to get this working. If I had known about it when I first started this work, I would probably have done this just to get everything working again. But the longer-term fix is already in this PR.
Use UBI8 in the UI tests
Red Hat folks have explicitly stated that X11 packages will not be supported in UBI registries.
CentOS Stream 9 across the board
This is problematic due to
CGO
andglibc
versions mismatching in CI. See the following PRs for more details:Future improvements
For a cleaner solution in the future, I propose we:
stackrox-build
andstackrox-test
into a single image that contains all tools that are required for development and running everything expected to work in GitHub Actions and Konfluxstackrox-ui-test
, possibly remain to something more meaningful (maybestackrox-osci
orstackrox-e2e-test
?), and also remove all unnecessary dependencies and packages after investigating them