Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking merging on translations #3241

Merged
merged 68 commits into from
Mar 19, 2024
Merged

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Feb 1, 2024

Summary

  • Adds a script requiring translations to exist in Lokalise with a way to opt-out with a PR label

Motivation

Localization automation

Testing

See PR history

Changelog

N/A

@porter-stripe porter-stripe force-pushed the porter/automate-localizations branch from eabf114 to 2970b63 Compare March 15, 2024 17:23
@stripe stripe deleted a comment from github-actions bot Mar 15, 2024
Copy link

github-actions bot commented Mar 15, 2024

⚠️ Missing Translations

The following translations are missing in Lokalise. While they don't need to be downloaded into the codebase as part of this PR, they do need to exist in Lokalise so that they can be downloaded as part of the release process.

This is not in lokalise translated, This is not in lokalise translated2

By adding the label ship without translations to this PR, I acknowledge that there are missing translations.

@porter-stripe porter-stripe marked this pull request as ready for review March 18, 2024 15:23
@porter-stripe porter-stripe requested review from a team as code owners March 18, 2024 15:23
@porter-stripe porter-stripe requested review from sgrant-stripe and davidme-stripe and removed request for sgrant-stripe March 18, 2024 15:23
@porter-stripe porter-stripe changed the title Automate localizations Blocking merging on translations Mar 19, 2024
@porter-stripe porter-stripe merged commit ff966b4 into master Mar 19, 2024
2 checks passed
@porter-stripe porter-stripe deleted the porter/automate-localizations branch March 19, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants