Blocking merging on translations

.github/workflows/check-translations.yml

@@ -0,0 +1,65 @@
+name: Check Missing Translations
+on:
+  pull_request:
+    types: [opened, labeled, unlabeled, synchronize]
+    paths:
+      - '**/Localizable.strings' # Only run this check if localized string files have changed, exclude non-payments projects.
+      - '!StripeFinancialConnections/**'
+      - '!StripeIdentity/**'
+      - '!StripeConnections/**'
+
+jobs:
+  check-translations:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v1
+        with:
+            fetch-depth: 0
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.0
+      - name: Install dependencies
+        run: gem install net-http net-uri json
+      - name: Run translation check script
+        env:
+          LOKALISE_API_KEY: ${{ secrets.LOKALISE_API_KEY_READONLY }}
+        run: ruby ci_scripts/check_for_untranslated_strings.rb
+      - name: Read missing translations
+        id: missing
+        run: echo "::set-output name=translations::$(<missing_translations.txt)"
+      - name: Exit if no missing translations
+        id: check_translations
+        run: |
+          if [ -z "${{ steps.missing.outputs.translations }}" ]; then
+            echo "No missing translations found, exiting..."
+            exit 0
+          else
+            echo "Missing translations detected, continue workflow..."
+          fi
+      - uses: peter-evans/[email protected]
+        id: find_comment
+        with:
+          issue-number: ${{ github.event.pull_request.number }}
+          body-includes: Missing Translations
+      - uses: peter-evans/create-or-update-comment@v4
+        with:
+          body: |
+            ⚠️ Missing Translations
+
+            The following translations are missing in Lokalise. While they don't need to be downloaded into the codebase as part of this PR, they do need to exist in Lokalise so that they can be downloaded as part of the release process.
+
+            ${{ steps.missing.outputs.translations }}
+
+            By adding the label `ship without translations` to this PR, I acknowledge that there are missing translations.
+          edit-mode: replace
+          comment-id: ${{ steps.find_comment.outputs.comment-id }}
+          issue-number: ${{ github.event.pull_request.number }}
+          token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Fail if not accepted
+        if: "steps.missing.outputs.translations && !contains(github.event.pull_request.labels.*.name, 'ship without translations')"
+        run: exit 1

ci_scripts/check_for_untranslated_strings.rb

@@ -0,0 +1,71 @@
+require 'net/http'
+require 'json'
+require 'uri'
+
+$SCRIPT_DIR = __dir__
+$ROOT_DIR = File.expand_path('..', $SCRIPT_DIR)
+
+def api_get_request(endpoint, token)
+  uri = URI(endpoint)
+  req = Net::HTTP::Get.new(uri)
+  req['X-Api-Token'] = token
+
+  res = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
+    http.request(req)
+  end
+
+  JSON.parse(res.body)
+end
+
+def get_added_strings(current_dir)
+  new_strings = {}
+
+  strings_files = `git diff --name-only origin/master...`.split("\n").select { |f| f.end_with?(".strings") }
+
+  strings_files.each do |file|
+    added_lines = `git diff origin/master... -- #{file}`.split("\n").select do |line|
+      line.start_with?('+') && !line.start_with?('+++') && line.include?('=') && !line.match(/^\/\//)
+    end
+
+    new_strings[file] = added_lines.map do |line|
+      line.delete_prefix('+').strip.split('=')[0].gsub(/\"/, '').strip
+    end
+  end
+
+  new_strings
+end
+
+def check_lokalise_translations(api_token, project_id, new_added_strings)
+  keys = api_get_request("https://api.lokalise.com/api2/projects/#{project_id}/keys?limit=5000&include_translations=1", api_token)
+  missing_translations = []
+
+  new_added_strings.each do |file_path, new_strings|
+    puts "Checking translation for file #{file_path}"
+
+    new_strings.each do |str|
+      key = keys['keys'].find { |k| k['key_name']['other'] == str }
+
+      if key
+        translated_count = key['translations'].count { |t| !t['translation'].empty? }
+        if translated_count > 30
+          puts "Translations for '#{str}' exists."
+        else
+          puts "Translations for '#{str}' do not exist."
+          missing_translations << str
+        end
+      else
+        puts "String '#{str}' does not exist. Make sure you have uploaded your strings to Lokalise."
+        missing_translations << str
+      end
+    end
+  end
+
+  missing_translations
+end
+
+new_strings_added = get_added_strings($ROOT_DIR)
+missing_translations = check_lokalise_translations(ENV['LOKALISE_API_KEY'], '747824695e51bc2f4aa912.89576472', new_strings_added)
+puts(missing_translations)
+if missing_translations.any?
+  File.open("missing_translations.txt", 'w') { |f| f.write missing_translations.join(", ") }
+end