-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aachen Turbine Tutorial #56
base: develop
Are you sure you want to change the base?
Conversation
@joshkellyjak, could you review this PR? |
Hey Josh, could you have a look at this, so that we can finally close it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a copy of the test in TestCases?
Hi Pedro, the mesh is the same |
Then can we put this case in the tutorials.py regression and remove the one from TestCases? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that this should be run as a regression test also
% Author: S. Vitale, A. Cappiello % | ||
% Institution: Delft University of Technology % | ||
% Date: Oct 20th, 2023 % | ||
% % |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the version this works for?
VISCOSITY_MODEL= SUTHERLAND | ||
% | ||
% Molecular Viscosity that would be constant (1.716E-5 by default) | ||
MU_CONSTANT= 1.716E-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this does anything so maybe best to remove it to avoid confusing between this and MU_REF
% | ||
% Inflow and Outflow markers must be specified, for each blade (zone), following the natural groth of the machine (i.e, from the first blade to the last) | ||
MARKER_TURBOMACHINERY= (INFLOW_STATOR1, OUTFLOW_STATOR1, INFLOW_ROTOR, OUTFLOW_ROTOR, INFLOW_STATOR2, OUTFLOW_STATOR2) | ||
MARKER_ANALYZE = (INFLOW_STATOR1, OUTFLOW_STATOR2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to surface identification section for consistency with config_template
% | ||
JST_SENSOR_COEFF= ( 0.5, 0.25 ) | ||
% Spatial numerical order integration | ||
MUSCL_FLOW= NO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this option too
% Reduction factor of the CFL coefficient in the turbulence problem | ||
CFL_REDUCTION_TURB= 0.1 | ||
% | ||
% ----------------------- DESIGN VARIABLE PARAMETERS --------------------------% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this whole section is necessary, let's save it for the turbo adjoint tutorial
config and mesh files for the Aachen Turbine tutorial